Messages in this thread | | | Date | Sat, 22 Aug 2020 18:46:19 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds |
| |
On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > > > We would overrun the error_text array if we hit a TIMEOUT condition, > > > because we were using the error code "ETIMEDOUT" (which is 110) as an > > > array index. > > > > > > We fix the problem by correcting the array index and by providing a > > > function to retrieve error messages rather than accessing the array > > > directly. The function includes a bounds check that prevents the array > > > from being overrun. > > > > > > This patch was prepared in response to > > > https://lkml.org/lkml/2020/8/18/505. > > > > > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > > > > Your Signed-off-by does not match From field. Please run > > scripts/checkpatch on every patch you send. > > > > I fixed it up, assuming markus.mayer@broadcom.com is the valid email > > address. > > No. I have always been using mmayer@broadcom.com since it is shorter. > That's also what's in the MAINTAINERS file. Please change it back. I > accidentally used the long form for one of my e-mail replies which is > where the confusion must have originated.
I'll drop the patch then. You need to resend with SoB matching email.
Best regards, Krzysztof
| |