Messages in this thread | | | Date | Fri, 21 Aug 2020 15:20:59 +0200 | From | Stefan Agner <> | Subject | Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp |
| |
On 2020-08-20 06:10, Chris Healy wrote: > From: Chris Healy <cphealy@gmail.com> > > Add syscon compatibility with Vybrid ocotp node. This is required to > access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.
Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.
-- Stefan
> > Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") > Cc: stable@vger.kernel.org > Signed-off-by: Chris Healy <cphealy@gmail.com> > --- > Changes in v2: > - Add Fixes line to commit message > > arch/arm/boot/dts/vfxxx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 0fe03aa0367f..2259d11af721 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { > }; > > ocotp: ocotp@400a5000 { > - compatible = "fsl,vf610-ocotp"; > + compatible = "fsl,vf610-ocotp", "syscon"; > reg = <0x400a5000 0x1000>; > clocks = <&clks VF610_CLK_OCOTP>; > };
| |