Messages in this thread | | | Date | Fri, 21 Aug 2020 10:30:28 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] thermal: sysfs: Fall back to vmalloc() for cooling device's statistics |
| |
On 21-08-20, 10:44, Yue Hu wrote: > From: Yue Hu <huyue2@yulong.com> > > We observed warning about kzalloc() when register thermal cooling device > in backlight_device_register(). backlight display can be a cooling device > since reducing screen brightness will can help reduce temperature. > > However, ->get_max_state of backlight will assign max brightness of 1024 > to states. The memory size can be getting 1MB+ due to states * states. > That is so large to trigger kmalloc() warning. > > So, let's use kvzalloc() to avoid the issue, also change kfree -> kvfree. > > Suggested-by: Amit Kucheria <amitk@kernel.org> > Signed-off-by: Yue Hu <huyue2@yulong.com> > --- > drivers/thermal/thermal_sysfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |