lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 16/61] staging: rts5208: fix memleaks on error handling paths in probe
    Date
    From: Evgeny Novikov <novikov@ispras.ru>

    [ Upstream commit 11507bf9a8832741db69efd32bf09a2ab26426bf ]

    rtsx_probe() allocates host, but does not free it on error handling
    paths. The patch adds missed scsi_host_put().

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
    Link: https://lore.kernel.org/r/20200623141230.7258-1-novikov@ispras.ru
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/rts5208/rtsx.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
    index be0053c795b7a..937f4e732a75c 100644
    --- a/drivers/staging/rts5208/rtsx.c
    +++ b/drivers/staging/rts5208/rtsx.c
    @@ -972,6 +972,7 @@ static int rtsx_probe(struct pci_dev *pci,
    kfree(dev->chip);
    chip_alloc_fail:
    dev_err(&pci->dev, "%s failed\n", __func__);
    + scsi_host_put(host);
    scsi_host_alloc_fail:
    pci_release_regions(pci);
    return err;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-21 19:21    [W:4.458 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site