Messages in this thread | | | Date | Fri, 21 Aug 2020 17:11:05 +0000 | From | Fenghua Yu <> | Subject | Re: [PATCH 2/2] x86/resctrl: Enable user to view thread or core throttling mode |
| |
On Fri, Aug 21, 2020 at 03:13:17PM +0200, Borislav Petkov wrote: > On Thu, Jul 16, 2020 at 10:53:14AM -0700, Fenghua Yu wrote: > > struct rdt_membw { > > + enum membw_throttle_mode arch_throttle_mode; > > I guess "arch" is implicit so you can > > s/arch_throttle_mode/throttle_mode/g Ok. Will fix this. > > ... > > > +static struct rftype *rdtgroup_rftype_by_name(const char *name) > > That function name needs a verb.
I will change it to rdtgroup_rftype_get_by_name().
Thank you very much for your review!
-Fenghua > https://people.kernel.org/tglx/notes-about-netiquette
| |