Messages in this thread | | | Subject | Re: [PATCH 2/8] KVM: nSVM: rename nested 'vmcb' to vmcb_gpa in few places | From | Paolo Bonzini <> | Date | Thu, 20 Aug 2020 12:19:15 +0200 |
| |
On 20/08/20 12:00, Maxim Levitsky wrote: >> Please use vmcb12_gpa, and svm->nested.vmcb12 for the VMCB in patch 6. >> >> (You probably also what to have local variables named vmcb12 in patch 6 >> to avoid too-long lines). > The limit was raised to 100 chars recently, thats why I allowed some lines to > go over 80 characters to avoid adding too much noise. >
True, but having svm->nested.vmcb12->control repeated all over isn't pretty. :)
Since you're going to touch all lines anyway, adding the local variable is a good idea.
Paolo
| |