Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | John Garry <> | Subject | [PATCH v8 02/18] blk-mq: Rename blk_mq_update_tag_set_depth() | Date | Wed, 19 Aug 2020 23:20:20 +0800 |
| |
From: Hannes Reinecke <hare@suse.de>
The function does not set the depth, but rather transitions from shared to non-shared queues and vice versa.
So rename it to blk_mq_update_tag_set_shared() to better reflect its purpose.
Signed-off-by: Hannes Reinecke <hare@suse.de> [jpg: take out some unrelated changes in blk_mq_init_bitmap_tags()] Signed-off-by: John Garry <john.garry@huawei.com> --- block/blk-mq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c index 8f95cc443527..50de9eb60466 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2880,8 +2880,8 @@ static void queue_set_hctx_shared(struct request_queue *q, bool shared) } } -static void blk_mq_update_tag_set_depth(struct blk_mq_tag_set *set, - bool shared) +static void blk_mq_update_tag_set_shared(struct blk_mq_tag_set *set, + bool shared) { struct request_queue *q; @@ -2904,7 +2904,7 @@ static void blk_mq_del_queue_tag_set(struct request_queue *q) /* just transitioned to unshared */ set->flags &= ~BLK_MQ_F_TAG_QUEUE_SHARED; /* update existing queue */ - blk_mq_update_tag_set_depth(set, false); + blk_mq_update_tag_set_shared(set, false); } mutex_unlock(&set->tag_list_lock); INIT_LIST_HEAD(&q->tag_set_list); @@ -2922,7 +2922,7 @@ static void blk_mq_add_queue_tag_set(struct blk_mq_tag_set *set, !(set->flags & BLK_MQ_F_TAG_QUEUE_SHARED)) { set->flags |= BLK_MQ_F_TAG_QUEUE_SHARED; /* update existing queue */ - blk_mq_update_tag_set_depth(set, true); + blk_mq_update_tag_set_shared(set, true); } if (set->flags & BLK_MQ_F_TAG_QUEUE_SHARED) queue_set_hctx_shared(q, true); -- 2.26.2
| ![\](/images/icornerr.gif) |