Messages in this thread | | | Date | Wed, 19 Aug 2020 16:51:58 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] x86: Make source of unrecognised MSR writes unambiguous |
| |
On Mon, Aug 17, 2020 at 04:24:36PM +0100, Chris Down wrote: > In many cases the comm enough isn't enough to distinguish the offender, > since for interpreted languages it's likely just going to be "python3" > or whatever. Add the pid to make it unambiguous. > > Signed-off-by: Chris Down <chris@chrisdown.name> > Cc: Borislav Petkov <bp@suse.de> > Cc: Jakub Kicinski <kuba@kernel.org> > --- > arch/x86/kernel/msr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c > index 3babb0e58b0e..76b6b0011d62 100644 > --- a/arch/x86/kernel/msr.c > +++ b/arch/x86/kernel/msr.c > @@ -99,8 +99,9 @@ static int filter_write(u32 reg) > if (!__ratelimit(&fw_rs) || reg == MSR_IA32_ENERGY_PERF_BIAS) > return 0; > > - pr_err("Write to unrecognized MSR 0x%x by %s\n" > - "Please report to x86@kernel.org\n", reg, current->comm); > + pr_err("Write to unrecognized MSR 0x%x by pid %s:%d\n"
Perhaps make that "... by %s (pid: %d)\n".
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |