Messages in this thread | | | Subject | Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c | From | "Leizhen (ThunderTown)" <> | Date | Wed, 19 Aug 2020 22:18:23 +0800 |
| |
On 8/19/2020 9:35 PM, Oliver O'Halloran wrote: > On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <Markus.Elfring@web.de> wrote: >> >>> The memory priv->bus_desc.provider_name allocated by kstrdup() is not >>> freed correctly. > > Personally I thought his commit message was perfectly fine. A little > unorthodox, but it works. > >> How do you think about to choose an imperative wording for >> a corresponding change description? > > ...but this! This is word salad.
Talented students are trained by strict teacher. All of us is trying to make things better.
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151 >> >> Regards, >> Markus > >
| |