lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c
From
Date


On 8/19/2020 9:35 PM, Oliver O'Halloran wrote:
> On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>>
>>> The memory priv->bus_desc.provider_name allocated by kstrdup() is not
>>> freed correctly.
>
> Personally I thought his commit message was perfectly fine. A little
> unorthodox, but it works.
>
>> How do you think about to choose an imperative wording for
>> a corresponding change description?
>
> ...but this! This is word salad.

Talented students are trained by strict teacher. All of us is trying to make things better.

>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>>
>> Regards,
>> Markus
>
>

\
 
 \ /
  Last update: 2020-08-19 16:19    [W:0.637 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site