Messages in this thread | | | From | Lukasz Stelmach <> | Subject | Re: [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath() | Date | Wed, 19 Aug 2020 14:51:27 +0200 |
| |
It was <2020-08-19 śro 14:38>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:01PM +0200, Łukasz Stelmach wrote: >> Fix issues with DMA transfers bigger than 512 on Exynos3250. > > Fix, but how? With proper explanation this should go to CC-stable.
Honestly, I don't know and I couldn't find out why. It makes stuff work. There has been a commit like this before
0f5a751ace25 spi/s3c64xx: Enable GPIO /CS prior to starting hardware
Apparently, it was lost in
0732a9d2a155 spi/s3c64xx: Use core message handling
>> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> >> --- >> drivers/spi/spi-s3c64xx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index cf67ea60dc0e..fb5e2ba4b6b9 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -678,11 +678,11 @@ static int s3c64xx_spi_transfer_one(struct spi_master *master, >> sdd->state &= ~RXBUSY; >> sdd->state &= ~TXBUSY; >> >> - s3c64xx_enable_datapath(sdd, xfer, use_dma); >> - >> /* Start the signals */ >> s3c64xx_spi_set_cs(spi, true); >> >> + s3c64xx_enable_datapath(sdd, xfer, use_dma); >> + >> spin_unlock_irqrestore(&sdd->lock, flags); >> >> if (use_dma) >> -- >> 2.26.2 >>
-- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics [unhandled content-type:application/pgp-signature] | |