Messages in this thread | | | From | Ilya Dryomov <> | Date | Wed, 19 Aug 2020 11:00:45 +0200 | Subject | Re: [PATCH] ceph: Convert to use the preferred fallthrough macro |
| |
On Wed, Aug 19, 2020 at 10:53 AM Miaohe Lin <linmiaohe@huawei.com> wrote: > > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Hongxiang Lou <louhongxiang@huawei.com> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > fs/ceph/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index d51c3f2fdca0..30cd00265181 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -252,7 +252,7 @@ static int ceph_init_file(struct inode *inode, struct file *file, int fmode) > case S_IFREG: > ceph_fscache_register_inode_cookie(inode); > ceph_fscache_file_set_cookie(inode, file); > - /* fall through */ > + fallthrough; > case S_IFDIR: > ret = ceph_init_file_info(inode, file, fmode, > S_ISDIR(inode->i_mode)); > -- > 2.19.1 >
Hi Miaohe,
I've already done that, folding into your previous patch:
https://github.com/ceph/ceph-client/commit/3f19ae89547df1b8ccba359a2f7ddba0f108ffbd
Thanks,
Ilya
| |