lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 073/168] media: firewire: Using uninitialized values in node_probe()
On Tue, Aug 18, 2020 at 11:34:53PM +0200, Pavel Machek wrote:
> Hi!
>
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > [ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ]
> >
> > If fw_csr_string() returns -ENOENT, then "name" is uninitialized. So
> > then the "strlen(model_names[i]) <= name_len" is true because strlen()
> > is unsigned and -ENOENT is type promoted to a very high positive value.
> > Then the "strncmp(name, model_names[i], name_len)" uses uninitialized
> > data because "name" is uninitialized.
>
> This causes memory leak, AFAICT.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>

Again, this is not how to submit patches, and you know this.

You are one more email-like-this away from my circular-file filter...

greg k-h

\
 
 \ /
  Last update: 2020-08-19 07:46    [W:0.126 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site