Messages in this thread | | | Subject | Re: [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board | From | Landen Chao <> | Date | Wed, 19 Aug 2020 16:15:01 +0800 |
| |
On Wed, 2020-08-19 at 00:24 +0800, Vladimir Oltean wrote: > On Tue, Aug 18, 2020 at 03:14:12PM +0800, Landen Chao wrote: > > Add mt7531 dsa to bananapi-bpi-r64 board for 5 giga Ethernet ports support. > > > > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > > --- > > .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > index d174ad214857..c57b2571165f 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts > > @@ -143,6 +143,50 @@ > > mdio: mdio-bus { > > #address-cells = <1>; > > #size-cells = <0>; > > + > > + switch@0 { > > + compatible = "mediatek,mt7531"; > > + [snip] > > + port@6 { > > + reg = <6>; > > + label = "cpu"; > > + ethernet = <&gmac0>; > > + phy-mode = "2500base-x"; > > + }; > > Is there any reason why you're not specifying a fixed-link node here? I got the below feedback in v1, so I follow the DSA common design in v2. v2 can work with fixed-link node or without fixed-link node in CPU port node.
"This fixed-link should not be needed. The DSA driver is supposed to configure the CPU port to its fastest speed by default. 2500 is the fastest speed a 2500Base-X link can do..." > > + }; > > + }; > > + > > }; > > }; > > > > -- > > 2.17.1 > > Thanks, > -Vladimir
| |