Messages in this thread | | | From | "Z.q. Hou" <> | Subject | RE: [PATCHv2] PCI: designware-ep: Fix the Header Type check | Date | Wed, 19 Aug 2020 04:55:43 +0000 |
| |
Hi Rob,
Thanks a lot for your review!
Regards, Zhiqiang
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 2020年8月18日 21:52 > To: Z.q. Hou <zhiqiang.hou@nxp.com> > Cc: linux-kernel@vger.kernel.org; PCI <linux-pci@vger.kernel.org>; Lorenzo > Pieralisi <lorenzo.pieralisi@arm.com>; Bjorn Helgaas > <bhelgaas@google.com>; Andrew Murray > <amurray@thegoodpenguin.co.uk>; Jingoo Han <jingoohan1@gmail.com>; > Gustavo Pimentel <gustavo.pimentel@synopsys.com> > Subject: Re: [PATCHv2] PCI: designware-ep: Fix the Header Type check > > On Tue, Aug 18, 2020 at 3:35 AM Zhiqiang Hou <Zhiqiang.Hou@nxp.com> > wrote: > > > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > > > The current check will result in the multiple function device fails to > > initialize. So fix the check by masking out the multiple function bit. > > > > Fixes: 0b24134f7888 ("PCI: dwc: Add validation that PCIe core is set > > to correct mode") > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > --- > > V2: > > - Add marco PCI_HEADER_TYPE_MASK and print the masked value. > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 3 ++- > > include/uapi/linux/pci_regs.h | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > Reviewed-by: Rob Herring <robh@kernel.org>
| |