lkml.org 
[lkml]   [2020]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers
On Tue, Aug 18, 2020 at 9:03 PM Kenneth Chan <kenneth.t.chan@gmail.com> wrote:
>

Thank you for a patch, but it misses few crucial points:
- it should have good description as commit message (body of this letter)
- it should have signature of origin (Signed-off-by tag) that I can
proceed (I see, it's in wrong position, use `git commit -s` to fix
this)
- it should be split per one logical change in a patch, e.g. 1)
replacing ACPI prints by pr_*() macros, 2) split MODULE_AUTHOR() by
one author per macro call, 3) etc...


> Signed-off-by: Kenneth Chan <kenneth.t.chan@gmail.com>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-08-19 09:50    [W:0.037 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site