Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH drm/hisilicon v2 0/4] Use drm_err instead of DRM_ERROR in hibmc driver | From | Thomas Zimmermann <> | Date | Wed, 19 Aug 2020 20:06:33 +0200 |
| |
Hi
Am 19.08.20 um 11:23 schrieb Tian Tao: > patch #1 is using the drm_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drm_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drm_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in hibmc_drm_de.c > patch #4 is using the drm_err and drm_warn instead of DRM_ERROR and > DRM_WARN in hibmc_drm_drv.c > > Changes since v1: > -Fixed spelling errors in patch name.
Just a few formal nits: it's common to also log the changes in the patches themselves. And as I already R-b'ed the patchset, the patches should contain the tag.
So
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
for the whole series. If no one else has comments, it should be fine to merge the patches by the end of the week.
Best regards Thomas
> > Tian Tao (4): > drm/hisilicon: Use drm_err instead of DRM_ERROR in hibmc_ttm > drm/hisilicon: Use drm_err instead of DRM_ERROR in hibmc_drm_vdac > drm/hisilicon: Use drm_err instead of DRM_ERROR in hibmc_drm_de > drm/hisilicon: Use drm_err instead of DRM_ERROR in hibmc_drm_drv > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 14 +++++++------- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 24 ++++++++++++------------ > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 4 ++-- > drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 2 +- > 4 files changed, 22 insertions(+), 22 deletions(-) >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
[unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |