Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 18 Aug 2020 16:27:07 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON |
| |
On Tue, Aug 18, 2020 at 05:19:40PM +0300, Tomer Samara wrote: > On Tue, Aug 18, 2020 at 04:11:06PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Aug 16, 2020 at 10:23:25PM +0300, Tomer Samara wrote: > > > BUG_ON() is replaced with WARN_ON at ion_page_pool.c > > > > Why? > > > > > Fixes the following issue: > > > Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). > > > > Ideally you can get rid of WARN_ON() too, right? > > > > Many systems run in panic-on-warn mode, so this really does not change > > anything. Try fixing this up properly to not crash at all. > > > You mean by that to just remove the WARN_ON and leave the condition the > same?
Or fix the problem that could ever cause this check to fire.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |