lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/4] libnvdimm: add sanity check for provider_name in of_pmem_region_probe()
    Date
    kstrdup() may return NULL because of no memory, check it.

    Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    ---
    drivers/nvdimm/of_pmem.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
    index 1292ffca7b2ecc0..13c4c274ca6ea88 100644
    --- a/drivers/nvdimm/of_pmem.c
    +++ b/drivers/nvdimm/of_pmem.c
    @@ -31,6 +31,11 @@ static int of_pmem_region_probe(struct platform_device *pdev)
    return -ENOMEM;

    priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
    + if (!priv->bus_desc.provider_name) {
    + kfree(priv);
    + return -ENOMEM;
    + }
    +
    priv->bus_desc.module = THIS_MODULE;
    priv->bus_desc.of_node = np;

    --
    1.8.3

    \
     
     \ /
      Last update: 2020-08-19 04:06    [W:2.848 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site