lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] net: dsa: loop: Return VLAN table size through devlink
From
Date


On 8/18/2020 10:43 AM, Andrew Lunn wrote:
> On Mon, Aug 17, 2020 at 09:03:54PM -0700, Florian Fainelli wrote:
>> We return the VLAN table size through devlink as a simple parameter, we
>> do not support altering it at runtime:
>>
>> devlink resource show mdio_bus/fixed-0:1f
>> mdio_bus/fixed-0:1f:
>> name VTU size 4096 occ 4096 unit entry dpipe_tables none
>
> Hi Florian
>
> The occ 4096 looks wrong. It is supposed to show the occupancy, how
> many are in use.
>
>> +static u64 dsa_loop_devlink_vtu_get(void *priv)
>> +{
>> + struct dsa_loop_priv *ps = priv;
>> +
>> + return ARRAY_SIZE(ps->vlans);
>> +}
>
> So this should probably be looping over all vlan IDs and counting those
> with members?

Yes, I sent an incorrect version, thanks!
--
Florian

\
 
 \ /
  Last update: 2020-08-18 22:09    [W:0.041 / U:4.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site