lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/11] x86: make TASK_SIZE_MAX usable from assembly code
    On Tue, Aug 18, 2020 at 12:44:49PM -0700, Kees Cook wrote:
    > On Mon, Aug 17, 2020 at 09:32:09AM +0200, Christoph Hellwig wrote:
    > > For 64-bit the only hing missing was a strategic _AC, and for 32-bit we
    >
    > typo: thing
    >
    > > need to use __PAGE_OFFSET instead of PAGE_OFFSET in the TASK_SIZE
    > > definition to escape the explicit unsigned long cast. This just works
    > > because __PAGE_OFFSET is defined using _AC itself and thus never needs
    > > the cast anyway.
    >
    > Shouldn't this be folded into the prior patch so there's no bisection
    > problem?

    I didn't see a problem bisecting, do you have something particular in
    mind?

    \
     
     \ /
      Last update: 2020-08-18 21:56    [W:2.441 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site