Messages in this thread | ![/](/images/icornerl.gif) | | From | Aurélien Aptel <> | Subject | Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software. | Date | Fri, 14 Aug 2020 16:08:53 +0200 |
| |
Hi Konstantin,
That's cool :) As Nikolay said it needs a little change to the makefiles to even build.
Are you also going to publish your own mkfs.ntfs3 tool? I dont think the existing one would support 64k clusters.
I would recommend to run checkpatch (I see already 87 warnings... some of it is noise):
$ ./scripts/checkpatch.pl <patch>
And sparse (I dont see much):
$ touch fs/ntfs3/*.[ch] && make C=1
You need a recent build of sparse to do that last one. You can pass your own sparse bin (make CHECK=~/prog/sparse/sparse C=1)
This will be a good first step.
Have you tried to run the xfstests suite against it?
Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
| ![\](/images/icornerr.gif) |