Messages in this thread | | | From | "Shaikh, Azhar" <> | Subject | RE: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting usb role during disconnect | Date | Tue, 11 Aug 2020 19:39:04 +0000 |
| |
Hi,
> -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Sent: Tuesday, August 11, 2020 6:07 AM > To: Prashant Malani <pmalani@chromium.org>; Shaikh, Azhar > <azhar.shaikh@intel.com> > Cc: bleung@chromium.org; enric.balletbo@collabora.com; > groeck@chromium.org; linux-kernel@vger.kernel.org; Patel, Utkarsh H > <utkarsh.h.patel@intel.com>; Bowman, Casey G > <casey.g.bowman@intel.com>; Mani, Rajmohan > <rajmohan.mani@intel.com> > Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting > usb role during disconnect > > Hi, > > On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote: > > I would suggest: > > - Merging Patch 1 (role set correction) and Patch 2 (moving the > > usb_role_switch_set_role() inside cros_typec_configure_mux() > > *but* keep it at the end to preserve existing ordering) into 1 patch. > > - Add another patch which re-orders the calls and which in the commit > > message lists out all the reasons why this re-ordering needs to be > > done. > > > > Doing the above will help keep better track of why the changes were > made. > > So Azhar can you please prepare v3? >
Sure, sent v3.
> > thanks, > > -- > Heikki
Regards, Azhar
| |