lkml.org 
[lkml]   [2020]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/tls: Fix kmap usage
On Mon, 10 Aug 2020 17:02:58 -0700 ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> When MSG_OOB is specified to tls_device_sendpage() the mapped page is
> never unmapped.

Nice catch!

> Hold off mapping the page until after the flags are checked and the page
> is actually needed.

We could take the kmap/kunmap from under the socket lock, but that'd
perhaps be more code reshuffling than we need in a fix.

Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Reviewed-by: Jakub Kicinski <kuba@kernel.org>

\
 
 \ /
  Last update: 2020-08-11 18:02    [W:0.046 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site