Messages in this thread | | | Subject | Re: [PATCH] driver core: Let dev_err_probe() use the symbolic error code | From | Andrzej Hajda <> | Date | Tue, 11 Aug 2020 17:06:35 +0200 |
| |
Hi Uwe,
On 11.08.2020 09:20, Uwe Kleine-König wrote: > This makes the error message: > > error -EIO: ... > > instead of > > error -5: ... > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/base/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index ac1046a382bc..33734d8831c7 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -4237,10 +4237,10 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) > vaf.va = &args; > > if (err != -EPROBE_DEFER) { > - dev_err(dev, "error %d: %pV", err, &vaf); > + dev_err(dev, "error %pE: %pV", ERR_PTR(err), &vaf); > } else { > device_set_deferred_probe_reason(dev, &vaf); > - dev_dbg(dev, "error %d: %pV", err, &vaf); > + dev_dbg(dev, "error %pE: %pV", ERR_PTR(err), &vaf);
Apparently I have misread docs about %pE flag. Thanks for spotting this.
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Regards Andrzej
> } > > va_end(args);
| |