Messages in this thread | | | Date | Tue, 11 Aug 2020 20:24:48 +0800 | From | kernel test robot <> | Subject | Re: [PATCH] net: untag pointer in sockptr_is_kernel |
| |
Hi Miles,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on linus/master] [cannot apply to net/master hch-configfs/for-next sparc-next/master v5.8 next-20200811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Miles-Chen/net-untag-pointer-in-sockptr_is_kernel/20200811-183033 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bfdd5aaa54b0a44d9df550fe4c9db7e1470a11b8 config: x86_64-randconfig-s022-20200811 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-168-g9554805c-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/net.h:24, from net/core/stream.c:18: include/linux/sockptr.h: In function 'sockptr_is_kernel': >> include/linux/sockptr.h:23:24: error: implicit declaration of function 'untagged_addr' [-Werror=implicit-function-declaration] 23 | return (unsigned long)untagged_addr(sockptr.kernel) >= TASK_SIZE; | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/net.h:24, from net/ipv6/ip6_fib.c:20: include/linux/sockptr.h: In function 'sockptr_is_kernel': >> include/linux/sockptr.h:23:24: error: implicit declaration of function 'untagged_addr' [-Werror=implicit-function-declaration] 23 | return (unsigned long)untagged_addr(sockptr.kernel) >= TASK_SIZE; | ^~~~~~~~~~~~~ net/ipv6/ip6_fib.c: In function 'fib6_add': net/ipv6/ip6_fib.c:1373:25: warning: variable 'pn' set but not used [-Wunused-but-set-variable] 1373 | struct fib6_node *fn, *pn = NULL; | ^~ cc1: some warnings being treated as errors -- In file included from include/linux/net.h:24, from net/ipv6/udp.c:24: include/linux/sockptr.h: In function 'sockptr_is_kernel': >> include/linux/sockptr.h:23:24: error: implicit declaration of function 'untagged_addr' [-Werror=implicit-function-declaration] 23 | return (unsigned long)untagged_addr(sockptr.kernel) >= TASK_SIZE; | ^~~~~~~~~~~~~ net/ipv6/udp.c: At top level: net/ipv6/udp.c:1029:30: warning: no previous prototype for 'udp_v6_early_demux' [-Wmissing-prototypes] 1029 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb) | ^~~~~~~~~~~~~~~~~~ net/ipv6/udp.c:1070:29: warning: no previous prototype for 'udpv6_rcv' [-Wmissing-prototypes] 1070 | INDIRECT_CALLABLE_SCOPE int udpv6_rcv(struct sk_buff *skb) | ^~~~~~~~~ cc1: some warnings being treated as errors
vim +/untagged_addr +23 include/linux/sockptr.h
20 21 static inline bool sockptr_is_kernel(sockptr_t sockptr) 22 { > 23 return (unsigned long)untagged_addr(sockptr.kernel) >= TASK_SIZE; 24 } 25
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |