Messages in this thread | | | From | John Stultz <> | Date | Tue, 11 Aug 2020 19:06:03 -0700 | Subject | Re: [PATCH v2 1/2] ASoC: q6afe-dai: mark all widgets registers as SND_SOC_NOPM |
| |
On Tue, Aug 11, 2020 at 5:02 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > Looks like the q6afe-dai dapm widget registers are set as "0", > which is a not correct. > > As this registers will be read by ASoC core during startup > which will throw up errors, Fix this by making the registers > as SND_SOC_NOPM as these should be never used. > > With recent changes to ASoC core, every register read/write > failures are reported very verbosely. Prior to this fails to reads > are totally ignored, so we never saw any error messages. > > Reported-by: John Stultz <john.stultz@linaro.org> > Fixes: 24c4cbcfac09 ("ASoC: qdsp6: q6afe: Add q6afe dai driver") > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Changes since v1: > - replaced reg 0 with SND_SOC_NOPM and removed read callback >
For both patches: Tested-by: John Stultz <john.stultz@linaro.org>
thanks! -john
| |