lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] lockdep: warn on redundant or incorrect irq state changes
    Hi Nicholas,

    I love your patch! Yet something to improve:

    [auto build test ERROR on linux/master]
    [also build test ERROR on powerpc/next linus/master v5.8-rc6]
    [cannot apply to tip/locking/core next-20200723]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/lockdep-improve-current-hard-soft-irqs_enabled-synchronisation-with-actual-irq-state/20200723-185938
    base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68
    config: x86_64-randconfig-a002-20200723 (attached as .config)
    compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
    reproduce (this is a W=1 build):
    # save the attached .config to linux build tree
    make W=1 ARCH=x86_64

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    kernel/locking/lockdep.c: In function 'lockdep_init':
    >> kernel/locking/lockdep.c:5673:9: error: 'struct task_struct' has no member named 'hardirqs_enabled'
    5673 | current->hardirqs_enabled = 1;
    | ^~
    >> kernel/locking/lockdep.c:5674:9: error: 'struct task_struct' has no member named 'softirqs_enabled'
    5674 | current->softirqs_enabled = 1;
    | ^~
    In file included from kernel/locking/lockdep.c:60:
    At top level:
    kernel/locking/lockdep_internals.h:64:28: warning: 'LOCKF_USED_IN_IRQ_READ' defined but not used [-Wunused-const-variable=]
    64 | static const unsigned long LOCKF_USED_IN_IRQ_READ =
    | ^~~~~~~~~~~~~~~~~~~~~~
    In file included from kernel/locking/lockdep.c:60:
    kernel/locking/lockdep_internals.h:58:28: warning: 'LOCKF_ENABLED_IRQ_READ' defined but not used [-Wunused-const-variable=]
    58 | static const unsigned long LOCKF_ENABLED_IRQ_READ =
    | ^~~~~~~~~~~~~~~~~~~~~~
    In file included from kernel/locking/lockdep.c:60:
    kernel/locking/lockdep_internals.h:52:28: warning: 'LOCKF_USED_IN_IRQ' defined but not used [-Wunused-const-variable=]
    52 | static const unsigned long LOCKF_USED_IN_IRQ =
    | ^~~~~~~~~~~~~~~~~
    In file included from kernel/locking/lockdep.c:60:
    kernel/locking/lockdep_internals.h:46:28: warning: 'LOCKF_ENABLED_IRQ' defined but not used [-Wunused-const-variable=]
    46 | static const unsigned long LOCKF_ENABLED_IRQ =
    | ^~~~~~~~~~~~~~~~~

    vim +5673 kernel/locking/lockdep.c

    5667
    5668 printk(" per task-struct memory footprint: %zu bytes\n",
    5669 sizeof(((struct task_struct *)NULL)->held_locks));
    5670
    5671 WARN_ON(irqs_disabled());
    5672
    > 5673 current->hardirqs_enabled = 1;
    > 5674 current->softirqs_enabled = 1;
    5675 }
    5676

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-07-24 05:30    [W:2.371 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site