Messages in this thread | | | Subject | Re: [PATCH] fsi: fsi-occ: fix return value check in occ_probe() | From | Eddie James <> | Date | Mon, 13 Jul 2020 09:21:41 -0500 |
| |
On 7/12/20 10:33 PM, Xu Wang wrote: > In case of error, the function platform_device_register_full() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR().
Thanks,
Reviewed-by: Eddie James <eajames@linux.ibm.com>
> > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- > drivers/fsi/fsi-occ.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c > index 7da9c81759ac..9eeb856c8905 100644 > --- a/drivers/fsi/fsi-occ.c > +++ b/drivers/fsi/fsi-occ.c > @@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev) > > hwmon_dev_info.id = occ->idx; > hwmon_dev = platform_device_register_full(&hwmon_dev_info); > - if (!hwmon_dev) > + if (IS_ERR(hwmon_dev)) > dev_warn(dev, "failed to create hwmon device\n"); > > return 0;
| |