lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 27/35] powerpc: Tidy Success/Failure checks
    Date
    Remove unnecessary check for 0.

    Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
    ---
    This patch depends on PATCH 26/35

    arch/powerpc/platforms/powernv/eeh-powernv.c | 4 ++--
    arch/powerpc/platforms/pseries/eeh_pseries.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c
    index 92f145dc9c1d..834cb6175cc4 100644
    --- a/arch/powerpc/platforms/powernv/eeh-powernv.c
    +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
    @@ -318,7 +318,7 @@ static int pnv_eeh_find_ecap(struct pci_dn *pdn, int cap)

    if (!edev || !edev->pcie_cap)
    return 0;
    - if (pnv_pci_cfg_read(pdn, pos, 4, &header) != 0)
    + if (pnv_pci_cfg_read(pdn, pos, 4, &header))
    return 0;
    else if (!header)
    return 0;
    @@ -331,7 +331,7 @@ static int pnv_eeh_find_ecap(struct pci_dn *pdn, int cap)
    if (pos < 256)
    break;

    - if (pnv_pci_cfg_read(pdn, pos, 4, &header) != 0)
    + if (pnv_pci_cfg_read(pdn, pos, 4, &header))
    break;
    }

    diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
    index 9c023b928f2c..aec6f76879a9 100644
    --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
    +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
    @@ -200,7 +200,7 @@ static int pseries_eeh_find_ecap(struct pci_dn *pdn, int cap)

    if (!edev || !edev->pcie_cap)
    return 0;
    - if (rtas_read_config(pdn, pos, 4, &header) != 0)
    + if (rtas_read_config(pdn, pos, 4, &header))
    return 0;
    else if (!header)
    return 0;
    @@ -213,7 +213,7 @@ static int pseries_eeh_find_ecap(struct pci_dn *pdn, int cap)
    if (pos < 256)
    break;

    - if (rtas_read_config(pdn, pos, 4, &header) != 0)
    + if (rtas_read_config(pdn, pos, 4, &header))
    break;
    }

    --
    2.18.2
    \
     
     \ /
      Last update: 2020-07-13 15:24    [W:7.890 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site