Messages in this thread | | | From | Paul Durrant <> | Subject | RE: [PATCH v3 2/3] xen/privcmd: Mark pages as dirty | Date | Mon, 13 Jul 2020 09:09:08 +0100 |
| |
> -----Original Message----- > From: Souptick Joarder <jrdr.linux@gmail.com> > Sent: 12 July 2020 04:40 > To: boris.ostrovsky@oracle.com; jgross@suse.com; sstabellini@kernel.org > Cc: xen-devel@lists.xenproject.org; linux-kernel@vger.kernel.org; Souptick Joarder > <jrdr.linux@gmail.com>; John Hubbard <jhubbard@nvidia.com>; Paul Durrant <xadimgnik@gmail.com> > Subject: [PATCH v3 2/3] xen/privcmd: Mark pages as dirty > > pages need to be marked as dirty before unpinned it in > unlock_pages() which was oversight. This is fixed now. > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > Suggested-by: John Hubbard <jhubbard@nvidia.com> > Reviewed-by: Juergen Gross <jgross@suse.com> > Cc: John Hubbard <jhubbard@nvidia.com> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Paul Durrant <xadimgnik@gmail.com>
Reviewed-by: Paul Durrant <paul@xen.org>
> --- > drivers/xen/privcmd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index b001673..079d35b 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -611,8 +611,11 @@ static void unlock_pages(struct page *pages[], unsigned int nr_pages) > { > unsigned int i; > > - for (i = 0; i < nr_pages; i++) > + for (i = 0; i < nr_pages; i++) { > + if (!PageDirty(pages[i])) > + set_page_dirty_lock(pages[i]); > put_page(pages[i]); > + } > } > > static long privcmd_ioctl_dm_op(struct file *file, void __user *udata) > -- > 1.9.1
| |