lkml.org 
[lkml]   [2020]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 23/29] scsi: aacraid: linit: Provide suggested curly braces around empty body of if()
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
    drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    368 | param->heads, param->sectors, num));
    | ^

    Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
    Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/aacraid/linit.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
    index a308e86a97f19..734dd6e67246d 100644
    --- a/drivers/scsi/aacraid/linit.c
    +++ b/drivers/scsi/aacraid/linit.c
    @@ -363,9 +363,10 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev,

    param->cylinders = cap_to_cyls(capacity, param->heads * param->sectors);
    if (num < 4 && end_sec == param->sectors) {
    - if (param->cylinders != saved_cylinders)
    + if (param->cylinders != saved_cylinders) {
    dprintk((KERN_DEBUG "Adopting geometry: heads=%d, sectors=%d from partition table %d.\n",
    param->heads, param->sectors, num));
    + }
    } else if (end_head > 0 || end_sec > 0) {
    dprintk((KERN_DEBUG "Strange geometry: heads=%d, sectors=%d in partition table %d.\n",
    end_head + 1, end_sec, num));
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-13 09:48    [W:3.102 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site