lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY
    On Sat, Jul 11, 2020 at 12:36:10AM +0200, Alexandre Belloni wrote:
    > Hi Oleksij,
    >
    > This patch breaks Ethernet on the sama5d3 Xplained and I have not been
    > able to unbreak it.

    Hi Alexandre

    macb0: ethernet@f0028000 {
    phy-mode = "rgmii";
    #address-cells = <1>;
    #size-cells = <0>;
    status = "okay";

    ethernet-phy@7 {
    reg = <0x7>;
    };
    };

    So DT says it wants rgmii. How are the delays being added? Could the
    bootloader be configuring the PHY into rgmii-id mode, which is now
    getting cleared? Or by strapping of pins on the PHY?

    Also, looking at macb_main.c is seen:

    if (!(bp->caps & MACB_CAPS_USRIO_DISABLED)) {
    val = 0;
    if (bp->phy_interface == PHY_INTERFACE_MODE_RGMII)
    val = GEM_BIT(RGMII);
    else if (bp->phy_interface == PHY_INTERFACE_MODE_RMII &&
    (bp->caps & MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII))
    val = MACB_BIT(RMII);
    else if (!(bp->caps & MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII))
    val = MACB_BIT(MII);

    if (bp->caps & MACB_CAPS_USRIO_HAS_CLKEN)
    val |= MACB_BIT(CLKEN);

    macb_or_gem_writel(bp, USRIO, val);
    }

    I don't know if this applies for your hardware, but if you tried
    fixing the PHY by setting phy-mode to "rgmii-id", it could be macb
    then did not set GEM_BIT(RGMII) and so broken even more?

    Rather than bp->phy_interface == PHY_INTERFACE_MODE_RGMII,
    phy_interface_mode_is_rgmii() might work better.

    Andrew

    \
     
     \ /
      Last update: 2020-07-11 00:55    [W:8.681 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site