lkml.org 
[lkml]   [2020]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectR: [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064 bindings
    Date


    > -----Messaggio originale-----
    > Da: Rob Herring <robh@kernel.org>
    > Inviato: venerdì 10 luglio 2020 18:27
    > A: Ansuel Smith <ansuelsmth@gmail.com>
    > Cc: Amit Kucheria <amit.kucheria@linaro.org>; Andy Gross
    > <agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>;
    > Zhang Rui <rui.zhang@intel.com>; Daniel Lezcano
    > <daniel.lezcano@linaro.org>; linux-pm@vger.kernel.org; linux-arm-
    > msm@vger.kernel.org; devicetree@vger.kernel.org; linux-
    > kernel@vger.kernel.org
    > Oggetto: Re: [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064
    > bindings
    >
    > On Thu, Jul 09, 2020 at 11:51:33PM +0200, Ansuel Smith wrote:
    > > Document the use of regmap phandle for ipq8064 SoCs
    > >
    > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
    > > ---
    > > .../bindings/thermal/qcom-tsens.yaml | 51 ++++++++++++++++---
    > > 1 file changed, 44 insertions(+), 7 deletions(-)
    > >
    > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
    > b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
    > > index d7be931b42d2..5ceb5d720e16 100644
    > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
    > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
    > > @@ -24,6 +24,7 @@ properties:
    > > - enum:
    > > - qcom,msm8916-tsens
    > > - qcom,msm8974-tsens
    > > + - qcom,ipq8064-tsens
    > > - const: qcom,tsens-v0_1
    > >
    > > - description: v1 of TSENS
    > > @@ -47,6 +48,11 @@ properties:
    > > - description: TM registers
    > > - description: SROT registers
    > >
    > > + regmap:
    > > + description:
    > > + Phandle to the gcc. On ipq8064 SoCs gcc and tsense share the same
    > regs.
    > > + $ref: /schemas/types.yaml#/definitions/phandle
    >
    > Can't you make this a child of the gcc and drop this property?
    >

    Make the thermal a child of the gcc would be a little confusing. Anyway
    making this
    a child of gcc cause the not probing of the thermal driver as it's ignored
    any child of
    gcc. I pushed v2 with the fixed problem.

    > > +
    > > interrupts:
    > > minItems: 1
    > > items:
    > > @@ -111,17 +117,48 @@ allOf:
    > > interrupt-names:
    > > minItems: 2
    > >
    > > -required:
    > > - - compatible
    > > - - reg
    > > - - "#qcom,sensors"
    > > - - interrupts
    > > - - interrupt-names
    > > - - "#thermal-sensor-cells"
    > > + - if:
    > > + properties:
    > > + compatible:
    > > + contains:
    > > + enum:
    > > + - qcom,ipq8064-tsens
    > > + then:
    > > + required:
    > > + - compatible
    > > + - regmap
    > > + - "#qcom,sensors"
    > > + - interrupts
    > > + - interrupt-names
    > > + - "#thermal-sensor-cells"
    > > +
    > > + else:
    > > + required:
    > > + - compatible
    > > + - reg
    > > + - "#qcom,sensors"
    > > + - interrupts
    > > + - interrupt-names
    > > + - "#thermal-sensor-cells"
    >
    > Keep all the common required properties and just put reg/regmap in the
    > if/then if this ends up staying.
    >
    > Rob

    \
     
     \ /
      Last update: 2020-07-10 22:08    [W:5.841 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site