Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v2 15/17] arm64: Remove custom IRQ stat accounting | Date | Fri, 10 Jul 2020 20:58:50 +0100 |
| |
On 24/06/20 20:58, Marc Zyngier wrote: > Let's switch the arm64 code to the core accounting, which already > does everything we need. > > Signed-off-by: Marc Zyngier <maz@kernel.org> > --- > arch/arm64/include/asm/hardirq.h | 9 --------- > arch/arm64/kernel/smp.c | 24 ++++++------------------ > 2 files changed, 6 insertions(+), 27 deletions(-) > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index ed8a8184e3b6..8b903ceef2be 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -991,7 +979,7 @@ void __init set_smp_ipi_range(int ipi_base, int n) > int err; > > err = request_percpu_irq(ipi_base + i, ipi_handler, > - "IPI", &irq_stat); > + "IPI", &cpu_number);
That pointer remains unused in ipi_handler(); I suppose it's just a matter of cosmetics? I see that we leave it as irq_stat in arm, I suppose simply because we don't have a cpu_number equivalent there and need *some* percpu variable for the request to happen.
> WARN_ON(err); > > ipi_desc[i] = irq_to_desc(ipi_base + i);
| |