Messages in this thread | | | Date | Mon, 8 Jun 2020 21:42:45 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel() |
| |
On Mon, Jun 08, 2020 at 03:30:13PM -0400, Boris Ostrovsky wrote: > TBH I am not sure it's worth a new header file for a routine that is > only called from assembly (and never returns). I'd just add the > prototype right above function definition, with a comment describing > why.
Right, that works too.
> I see a few examples of this in the tree. Or maybe we even have an > attribute for this case?
Not that I'm aware of.
> (I also suspect the same may be needed for xen_prepare_pvh() BTW).
Yeah, Benni is working through the rest of them. Btw, the final goal of this whole work is to enable -Wmissing-prototypes by default on x86.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |