lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.6 147/606] scsi: qla2xxx: Do not log message when reading port speed via sysfs
    Date
    From: "Ewan D. Milne" <emilne@redhat.com>

    commit fb9024b0646939e59d8a0b6799b317070619795a upstream.

    Calling ql_log() inside qla2x00_port_speed_show() is causing messages to be
    output to the console for no particularly good reason. The sysfs read
    routine should just return the information to userspace. The only reason
    to log a message is when the port speed actually changes, and this already
    occurs elsewhere.

    Link: https://lore.kernel.org/r/20200504175416.15417-1-emilne@redhat.com
    Fixes: 4910b524ac9e ("scsi: qla2xxx: Add support for setting port speed")
    Cc: <stable@vger.kernel.org> # v5.1+
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Reviewed-by: Laurence Oberman <loberman@redhat.com>
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Ewan D. Milne <emilne@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/qla2xxx/qla_attr.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
    index 9556392652e3..e3c45edd0e18 100644
    --- a/drivers/scsi/qla2xxx/qla_attr.c
    +++ b/drivers/scsi/qla2xxx/qla_attr.c
    @@ -1777,9 +1777,6 @@ qla2x00_port_speed_show(struct device *dev, struct device_attribute *attr,
    return -EINVAL;
    }

    - ql_log(ql_log_info, vha, 0x70d6,
    - "port speed:%d\n", ha->link_data_rate);
    -
    return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 02:33    [W:8.754 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site