lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 026/175] rtw88: fix an issue about leak system resources
    Date
    From: Dejin Zheng <zhengdejin5@gmail.com>

    [ Upstream commit 191f6b08bfef24e1a9641eaac96ed030a7be4599 ]

    the related system resources were not released when pci_iomap() return
    error in the rtw_pci_io_mapping() function. add pci_release_regions() to
    fix it.

    Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
    Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
    Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20200504083442.3033-1-zhengdejin5@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/realtek/rtw88/pci.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
    index 77a2bdee50fa..4a43c4fa716d 100644
    --- a/drivers/net/wireless/realtek/rtw88/pci.c
    +++ b/drivers/net/wireless/realtek/rtw88/pci.c
    @@ -974,6 +974,7 @@ static int rtw_pci_io_mapping(struct rtw_dev *rtwdev,
    len = pci_resource_len(pdev, bar_id);
    rtwpci->mmap = pci_iomap(pdev, bar_id, len);
    if (!rtwpci->mmap) {
    + pci_release_regions(pdev);
    rtw_err(rtwdev, "failed to map pci memory\n");
    return -ENOMEM;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 02:14    [W:4.040 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site