Messages in this thread | | | Subject | Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init() | From | "yukuai (C)" <> | Date | Fri, 5 Jun 2020 17:08:37 +0800 |
| |
On 2020/6/5 3:07, Markus Elfring wrote: >> if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a >> corresponding put_device(). Thus add a jump target to fix the exception >> handling for this function implementation. > > Do you find a previous update suggestion useful? > > ARM: imx6: Add missing put_device() call in imx6q_suspend_init() > https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/ > https://lore.kernel.org/patchwork/patch/1151158/ > https://lkml.org/lkml/2019/11/9/125
Hi, Markus
It is useful indeed. Although I didn't run cocci script, since it can produce too many false result which is hard to filter out.
BTW, I see you haver done the work already, I guess I won't send any patches related to 'missing put_device after of_find_device_by_node()'. Any idea why these pathes didn't get applied ?
Best regards, Yu Kuai
| |