Messages in this thread | | | From | Maxim Uvarov <> | Date | Thu, 4 Jun 2020 17:45:19 +0300 | Subject | Re: [PATCH] checkpatch: Avoid missing typo suggestions |
| |
On Thu, 4 Jun 2020 at 10:29, Joe Perches <joe@perches.com> wrote: > > On Thu, 2020-06-04 at 09:55 +0300, Maxim Uvarov wrote: > > On Thu, 4 Jun 2020 at 03:39, Joe Perches <joe@perches.com> wrote: > > Hi Maxim. > > > > btw: My codespell dictionary file moved to > > > /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt > > > > > > and I had to use --codespell --codespellfile=(above) so > > > maybe there should be multiple lookups for this file > > > like the array below. > > > > > > Are there other standard codespell dictionary locations? > > > > It might be better to support standard and non standard locations. > > It already does with the --codespellfile=<location> opti. >
I mean if codespess is in your PATH then it will be good to query dictinary.txt. Even if you install codespell to your $HOME it still is possible to use it without manually specifying where is the file.
> > I think it's better to request from codespell where his dictionary is. > > Maybe a good idea, but looking at the codespell git, for > versions 1.17 on there are several standard dictionaries. > https://github.com/codespell-project/codespell/tree/v1.17.1/codespell_lib/data > > > I created ticket for this: > > https://github.com/codespell-project/codespell/issues/1540 > > Even if codespell is updated, the script would have to deal > with older versions that don't support requesting that option. >
Yes, we have to support old versions.
> cheers, Joe > >
| |