lkml.org 
[lkml]   [2020]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: v5.7: new core kernel option missing help text
    Date

    On 04/06/20 01:48, Thara Gopinath wrote:
    > Hi Russel/Valentin
    >
    > The feature itself like Valentin explained below allows scheduler to be
    > aware of cpu capacity reduced due to thermal throttling.
    > arch_set_thermal_pressure feeds the capped capacity to the scheduler and
    > hence the feature makes sense only if arch_set_thermal_pressure is
    > implemented. Having said that arch_set_thermal_pressure is implemented
    > in arch_topology driver for arm and arm64 platforms. But the feature
    > itself is not bound to arm/arm64 platforms. So it would make it wrong to
    > add a "depends on (ARM || ARM64) option."
    >
    > I agree with Vincent that allowing user to choose this option is
    > probably not the best. IMO, this should be enabled by default in arm64
    > defconfig considering both GENERIC_ARCH_TOPOLOGY and CPU_FREQ_THERMAL
    > are enabled by default.

    Right, I had skimmed over that but it probably does make more sense not
    to bother users with it.

    > So if it is acceptable three things to be done are:
    > 1. Add the help text.
    > 2. Don't allow SCHED_THERMAL_PRESSURE configurable by user
    > 3. Enable it by default in arm64 defconfig

    ... and arm as well, I suppose?

    \
     
     \ /
      Last update: 2020-06-04 11:27    [W:4.565 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site