lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check
    Date
    'rid' is declared as unsigned int, so there is little point checking for <0.

    Removing these checks fixes the following W=1 warnings:

    drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_enable’:
    drivers/regulator/tps65217-regulator.c:127:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    127 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
    | ^
    drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_disable’:
    drivers/regulator/tps65217-regulator.c:140:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    140 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
    | ^

    Cc: Russ Dill <Russ.Dill@ti.com>
    Cc: Keerthy <j-keerthy@ti.com>
    Cc: AnilKumar Ch <anilkumar@ti.com>
    Cc: linux-omap@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/regulator/tps65217-regulator.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
    index d27dbbafcf721..f2d3a4a9f3e77 100644
    --- a/drivers/regulator/tps65217-regulator.c
    +++ b/drivers/regulator/tps65217-regulator.c
    @@ -124,7 +124,7 @@ static int tps65217_pmic_set_suspend_enable(struct regulator_dev *dev)
    struct tps65217 *tps = rdev_get_drvdata(dev);
    unsigned int rid = rdev_get_id(dev);

    - if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
    + if (rid > TPS65217_LDO_4)
    return -EINVAL;

    return tps65217_clear_bits(tps, dev->desc->bypass_reg,
    @@ -137,7 +137,7 @@ static int tps65217_pmic_set_suspend_disable(struct regulator_dev *dev)
    struct tps65217 *tps = rdev_get_drvdata(dev);
    unsigned int rid = rdev_get_id(dev);

    - if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
    + if (rid > TPS65217_LDO_4)
    return -EINVAL;

    if (!tps->strobes[rid])
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-26 08:58    [W:2.352 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site