lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 3/3] media: vimc: Add a control to display info on test image
    Hi Kaaira,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on linuxtv-media/master]
    [also build test WARNING on v5.8-rc2 next-20200626]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Kaaira-Gupta/media-Add-colors-order-and-other-info-over-test-image/20200626-210915
    base: git://linuxtv.org/media_tree.git master
    config: s390-allyesconfig (attached as .config)
    compiler: s390-linux-gcc (GCC) 9.3.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    drivers/media/test-drivers/vimc/vimc-sensor.c: In function 'vimc_sen_process_frame':
    >> drivers/media/test-drivers/vimc/vimc-sensor.c:218:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    218 | tpg_gen_text(&vsen->tpg, basep, line++ * line_height,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    219 | 16, str);
    | ~~~~~~~~
    drivers/media/test-drivers/vimc/vimc-sensor.c:221:2: note: here
    221 | case OSD_SHOW_COUNTERS:
    | ^~~~

    vim +218 drivers/media/test-drivers/vimc/vimc-sensor.c

    186
    187 static void *vimc_sen_process_frame(struct vimc_ent_device *ved,
    188 const void *sink_frame)
    189 {
    190 struct vimc_sen_device *vsen = container_of(ved, struct vimc_sen_device,
    191 ved);
    192 enum osd_mode {OSD_SHOW_ALL = 0, OSD_SHOW_COUNTERS = 1, OSD_SHOW_NONE = 2};
    193 const unsigned int line_height = 16;
    194 u8 *basep[TPG_MAX_PLANES][2];
    195 unsigned int line = 1;
    196 char str[100];
    197
    198 tpg_fill_plane_buffer(&vsen->tpg, 0, 0, vsen->frame);
    199 tpg_calc_text_basep(&vsen->tpg, basep, 0, vsen->frame);
    200 switch (vsen->osd_mode) {
    201 case OSD_SHOW_ALL:
    202 {
    203 const char *order = tpg_g_color_order(&vsen->tpg);
    204
    205 tpg_gen_text(&vsen->tpg, basep,
    206 line++ * line_height, 16, order);
    207 snprintf(str, sizeof(str),
    208 "brightness %3d, contrast %3d, saturation %3d, hue %d ",
    209 vsen->tpg.brightness,
    210 vsen->tpg.contrast,
    211 vsen->tpg.saturation,
    212 vsen->tpg.hue);
    213 tpg_gen_text(&vsen->tpg, basep, line++ * line_height,
    214 16, str);
    215 snprintf(str, sizeof(str), "sensor size: %dx%d",
    216 vsen->mbus_format.width,
    217 vsen->mbus_format.height);
    > 218 tpg_gen_text(&vsen->tpg, basep, line++ * line_height,
    219 16, str);
    220 }
    221 case OSD_SHOW_COUNTERS:
    222 {
    223 unsigned int ms;
    224
    225 ms = (ktime_get_ns() - vsen->start_stream_ts) / 1000000;
    226 snprintf(str, sizeof(str), "%02d:%02d:%02d:%03d",
    227 (ms / (60 * 60 * 1000)) % 24,
    228 (ms / (60 * 1000)) % 60,
    229 (ms / 1000) % 60,
    230 ms % 1000);
    231 tpg_gen_text(&vsen->tpg, basep, line++ * line_height,
    232 16, str);
    233 break;
    234 }
    235 case OSD_SHOW_NONE:
    236 default:
    237 break;
    238 }
    239
    240 return vsen->frame;
    241 }
    242

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-06-26 17:36    [W:6.390 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site