Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 22 Jun 2020 09:32:00 -0700 | Subject | Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump |
| |
On Mon, Jun 22, 2020 at 9:24 AM Eric W. Biederman <ebiederm@xmission.com> wrote: > > Why do you think the test sig->group_exit_task != NULL should be removed > for the commit to make sense?
Because that's what your commit message _said_.
It still implies that with your changed language.
And honestly, wouldn't it be a lot more understandable if the state was tracked with a single variable? The whole point of this series has been "clarify exec".
So let's clarify it. There aren't that many places that set sig->group_exit_task (whether renamed or not). How about we just change _all_ of those to set 'sig->flags', and really clarify things?
Linus
| |