lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] spi: fsl: add missing __iomem annotation
    Date
    The field mspi->reg_base is annotated as an __iomem pointer. Good.

    However, this field is often assigned to a temporary variable:
    before being used. For example:
    struct fsl_spi_reg *reg_base = mspi->reg_base;

    But this variable is missing the __iomem annotation.
    So, add the missing __iomem and make sparse & the bot happier.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
    ---
    drivers/spi/spi-fsl-spi.c | 18 +++++++++---------
    1 file changed, 9 insertions(+), 9 deletions(-)

    diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c
    index 67f022b8c81d..299e9870cf58 100644
    --- a/drivers/spi/spi-fsl-spi.c
    +++ b/drivers/spi/spi-fsl-spi.c
    @@ -90,7 +90,7 @@ static void fsl_spi_change_mode(struct spi_device *spi)
    {
    struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
    struct spi_mpc8xxx_cs *cs = spi->controller_state;
    - struct fsl_spi_reg *reg_base = mspi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mspi->reg_base;
    __be32 __iomem *mode = &reg_base->mode;
    unsigned long flags;

    @@ -291,7 +291,7 @@ static int fsl_spi_cpu_bufs(struct mpc8xxx_spi *mspi,
    struct spi_transfer *t, unsigned int len)
    {
    u32 word;
    - struct fsl_spi_reg *reg_base = mspi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mspi->reg_base;

    mspi->count = len;

    @@ -309,7 +309,7 @@ static int fsl_spi_bufs(struct spi_device *spi, struct spi_transfer *t,
    bool is_dma_mapped)
    {
    struct mpc8xxx_spi *mpc8xxx_spi = spi_master_get_devdata(spi->master);
    - struct fsl_spi_reg *reg_base;
    + struct fsl_spi_reg __iomem *reg_base;
    unsigned int len = t->len;
    u8 bits_per_word;
    int ret;
    @@ -440,7 +440,7 @@ static int fsl_spi_do_one_msg(struct spi_master *master,
    static int fsl_spi_setup(struct spi_device *spi)
    {
    struct mpc8xxx_spi *mpc8xxx_spi;
    - struct fsl_spi_reg *reg_base;
    + struct fsl_spi_reg __iomem *reg_base;
    int retval;
    u32 hw_mode;
    struct spi_mpc8xxx_cs *cs = spi_get_ctldata(spi);
    @@ -495,7 +495,7 @@ static void fsl_spi_cleanup(struct spi_device *spi)

    static void fsl_spi_cpu_irq(struct mpc8xxx_spi *mspi, u32 events)
    {
    - struct fsl_spi_reg *reg_base = mspi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mspi->reg_base;

    /* We need handle RX first */
    if (events & SPIE_NE) {
    @@ -530,7 +530,7 @@ static irqreturn_t fsl_spi_irq(s32 irq, void *context_data)
    struct mpc8xxx_spi *mspi = context_data;
    irqreturn_t ret = IRQ_NONE;
    u32 events;
    - struct fsl_spi_reg *reg_base = mspi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mspi->reg_base;

    /* Get interrupt events(tx/rx) */
    events = mpc8xxx_spi_read_reg(&reg_base->event);
    @@ -550,7 +550,7 @@ static irqreturn_t fsl_spi_irq(s32 irq, void *context_data)
    static void fsl_spi_grlib_cs_control(struct spi_device *spi, bool on)
    {
    struct mpc8xxx_spi *mpc8xxx_spi = spi_master_get_devdata(spi->master);
    - struct fsl_spi_reg *reg_base = mpc8xxx_spi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mpc8xxx_spi->reg_base;
    u32 slvsel;
    u16 cs = spi->chip_select;

    @@ -568,7 +568,7 @@ static void fsl_spi_grlib_probe(struct device *dev)
    struct fsl_spi_platform_data *pdata = dev_get_platdata(dev);
    struct spi_master *master = dev_get_drvdata(dev);
    struct mpc8xxx_spi *mpc8xxx_spi = spi_master_get_devdata(master);
    - struct fsl_spi_reg *reg_base = mpc8xxx_spi->reg_base;
    + struct fsl_spi_reg __iomem *reg_base = mpc8xxx_spi->reg_base;
    int mbits;
    u32 capabilities;

    @@ -594,7 +594,7 @@ static struct spi_master *fsl_spi_probe(struct device *dev,
    struct fsl_spi_platform_data *pdata = dev_get_platdata(dev);
    struct spi_master *master;
    struct mpc8xxx_spi *mpc8xxx_spi;
    - struct fsl_spi_reg *reg_base;
    + struct fsl_spi_reg __iomem *reg_base;
    u32 regval;
    int ret = 0;

    base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
    --
    2.27.0

    \
     
     \ /
      Last update: 2020-06-22 18:26    [W:3.512 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site