lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v4 PATCH 0/3] Extend coredump functionality
On 2020-06-22 15:23, Bjorn Andersson wrote:
> On Wed 27 May 13:26 PDT 2020, Rishabh Bhatnagar wrote:
>
>> This patch series moves the coredump functionality to a separate
>> file and adds "inline" coredump feature. Inline coredump directly
>> copies segments from device memory during coredump to userspace.
>> This avoids extra memory usage at the cost of speed. Recovery is
>> stalled until all data is read by userspace.
>>
>> Changelog:
>>
>
> Hi Rishabh,
>
> This looks good to me, but it doesn't apply cleanly on linux-next. Can
> you please take a look?
>
> Regards,
> Bjorn
>
Yes some more gerrits have been merged in the meantime. I'll rebase on
top
of Linux-next and send out another patchset.
>> v4 -> v3:
>> - Write a helper function to copy segment memory for every dump format
>> - Change segment dump fn to add offset and size adn covert mss driver
>>
>> v3 -> v2:
>> - Move entire coredump functionality to remoteproc_coredump.c
>> - Modify rproc_coredump to perform dump according to conf. set by
>> userspace
>> - Move the userspace configuration to debugfs from sysfs.
>> - Keep the default coredump implementation as is
>>
>> v2 -> v1:
>> - Introduce new file for coredump.
>> - Add userspace sysfs configuration for dump type.
>>
>> Rishabh Bhatnagar (3):
>> remoteproc: Move coredump functionality to a new file
>> remoteproc: Add inline coredump functionality
>> remoteproc: Add coredump debugfs entry
>>
>> drivers/remoteproc/Makefile | 1 +
>> drivers/remoteproc/qcom_q6v5_mss.c | 9 +-
>> drivers/remoteproc/remoteproc_core.c | 191 ------------------
>> drivers/remoteproc/remoteproc_coredump.c | 328
>> +++++++++++++++++++++++++++++++
>> drivers/remoteproc/remoteproc_debugfs.c | 86 ++++++++
>> drivers/remoteproc/remoteproc_internal.h | 4 +
>> include/linux/remoteproc.h | 21 +-
>> 7 files changed, 443 insertions(+), 197 deletions(-)
>> create mode 100644 drivers/remoteproc/remoteproc_coredump.c
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>

\
 
 \ /
  Last update: 2020-06-23 04:45    [W:0.063 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site