Messages in this thread | | | Subject | Re: [PATCH net-next v3 2/7] dt-bindings: net: add backplane dt bindings | From | Florian Fainelli <> | Date | Mon, 22 Jun 2020 15:20:55 -0700 |
| |
On 6/22/20 6:35 AM, Florinel Iordache wrote: > Add ethernet backplane device tree bindings > > Signed-off-by: Florinel Iordache <florinel.iordache@nxp.com> > ---
[snip]
> +properties: > + $nodename: > + pattern: "^serdes(@[a-f0-9]+)?$" > + > + compatible: > + oneOf: > + - const: serdes-10g > + description: SerDes module type of 10G
Since this appears to be memory mapped in your case, it does not sound like "serdes-10g" alone is going to be sufficient, should not we have a SoC specific compatible string if nothing else?
> + > + reg: > + description: > + Registers memory map offset and size for this serdes module > + > + reg-names: > + description: > + Names of the register map given in "reg" node.
You would also need to describe how many of these two properties are expected.
> + > + little-endian: > + description: > + Specifies the endianness of serdes module > + For complete definition see > + Documentation/devicetree/bindings/common-properties.txt
This is redundant with the default binding then, and if it is not already in the common YAML binding, can you please add little-endian and native-endian added there?
> + > +examples: > + - | > + serdes1: serdes@1ea0000 { > + compatible = "serdes-10g"; > + reg = <0x0 0x1ea0000 0 0x00002000>; > + reg-names = "serdes", "serdes-10g"; > + little-endian; > + }; >
-- Florian
| |