lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 155/388] ASoC: component: suppress uninitialized-variable warning
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit be16a0f0dc8fab8e25d9cdbeb4f8f28afc9186d2 ]

    Old versions of gcc (tested on gcc-4.8) produce a warning for
    correct code:

    sound/soc/soc-compress.c: In function 'soc_compr_open':
    sound/soc/soc-compress.c:75:28: error: 'component' is used uninitialized in this function [-Werror=uninitialized]
    struct snd_soc_component *component, *save = NULL;

    Change the for_each_rtd_components() macro to ensure 'component'
    gets initialized to a value the compiler does not complain about.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20200428214754.3925368-1-arnd@arndb.de
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/sound/soc.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/sound/soc.h b/include/sound/soc.h
    index 946f88a6c63d..e0371e70242d 100644
    --- a/include/sound/soc.h
    +++ b/include/sound/soc.h
    @@ -1177,7 +1177,7 @@ struct snd_soc_pcm_runtime {
    #define asoc_rtd_to_codec(rtd, n) (rtd)->dais[n + (rtd)->num_cpus]

    #define for_each_rtd_components(rtd, i, component) \
    - for ((i) = 0; \
    + for ((i) = 0, component = NULL; \
    ((i) < rtd->num_components) && ((component) = rtd->components[i]);\
    (i)++)
    #define for_each_rtd_cpu_dais(rtd, i, dai) \
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:43    [W:6.397 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site