lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 242/266] NTB: perf: Fix support for hardware that doesn't have port numbers
    Date
    From: Logan Gunthorpe <logang@deltatee.com>

    [ Upstream commit b54369a248c2e033bfcf5d6917e08cf9d73d54a6 ]

    Legacy drivers do not have port numbers (but is reliably only two ports)
    and was broken by the recent commit that added mult-port support to
    ntb_perf. This is especially important to support the cross link
    topology which is perfectly symmetric and cannot assign unique port
    numbers easily.

    Hardware that returns zero for both the local port and the peer should
    just always use gidx=0 for the only peer.

    Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
    Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
    Acked-by: Allen Hubbe <allenbh@gmail.com>
    Tested-by: Alexander Fomichev <fomichev.ru@gmail.com>
    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ntb/test/ntb_perf.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
    index 3817eadab2cf..281170887ad0 100644
    --- a/drivers/ntb/test/ntb_perf.c
    +++ b/drivers/ntb/test/ntb_perf.c
    @@ -1423,6 +1423,16 @@ static int perf_init_peers(struct perf_ctx *perf)
    if (perf->gidx == -1)
    perf->gidx = pidx;

    + /*
    + * Hardware with only two ports may not have unique port
    + * numbers. In this case, the gidxs should all be zero.
    + */
    + if (perf->pcnt == 1 && ntb_port_number(perf->ntb) == 0 &&
    + ntb_peer_port_number(perf->ntb, 0) == 0) {
    + perf->gidx = 0;
    + perf->peers[0].gidx = 0;
    + }
    +
    for (pidx = 0; pidx < perf->pcnt; pidx++) {
    ret = perf_setup_peer_mw(&perf->peers[pidx]);
    if (ret)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 03:25    [W:4.051 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site