lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 111/134] scsi: lpfc: Fix negation of else clause in lpfc_prep_node_fc4type
    Date
    From: Dick Kennedy <dick.kennedy@broadcom.com>

    commit f809da6db68a8be49e317f0ccfbced1af9258839 upstream.

    Implementation of a previous patch added a condition to an if check that
    always end up with the if test being true. Execution of the else clause was
    inadvertently negated. The additional condition check was incorrect and
    unnecessary after the other modifications had been done in that patch.

    Remove the check from the if series.

    Link: https://lore.kernel.org/r/20200501214310.91713-5-jsmart2021@gmail.com
    Fixes: b95b21193c85 ("scsi: lpfc: Fix loss of remote port after devloss due to lack of RPIs")
    Cc: <stable@vger.kernel.org> # v5.4+
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
    Signed-off-by: James Smart <jsmart2021@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/lpfc/lpfc_ct.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/scsi/lpfc/lpfc_ct.c
    +++ b/drivers/scsi/lpfc/lpfc_ct.c
    @@ -462,7 +462,6 @@ lpfc_prep_node_fc4type(struct lpfc_vport
    struct lpfc_nodelist *ndlp;

    if ((vport->port_type != LPFC_NPIV_PORT) ||
    - (fc4_type == FC_TYPE_FCP) ||
    !(vport->ct_flags & FC_CT_RFF_ID) || !vport->cfg_restrict_login) {

    ndlp = lpfc_setup_disc_node(vport, Did);

    \
     
     \ /
      Last update: 2020-06-16 17:42    [W:4.138 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site