lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 RFC 1/2] spi: introduce fallback to pio
On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote:
> On 2020/06/15 22:56 Mark Brown <broonie@kernel.org> wrote:

> struct list_head transfer_list;
> +
> +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */
> + u16 flags;

I'd just make this a generic flag for failures before we start
interacting with the hardware rather than specifically this one error
case. Otherwise this looks fine.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-06-16 12:00    [W:0.112 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site